Issue 29453590: Issue 5287 - Change syntax for element hiding emulation filters and remove simplified element hidin…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29453590: Issue 5287 - Change syntax for element hiding emulation filters and remove simplified element hidin… (Closed)

Created:
June 1, 2017, 12:01 p.m. by Wladimir Palant

Modified:
June 1, 2017, 2:45 p.m.

Reviewers:
Sebastian Noack, hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 5287 - Change syntax for element hiding emulation filters and remove simplified element hiding syntax

Patch Set 1 #

Total comments: 3

Created: June 1, 2017, 12:01 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -173 lines)			Patch
M	chrome/content/elemHideEmulation.js	View	2 chunks	+49 lines, -5 lines	0 comments	Download
M	lib/filterClasses.js	View	3 chunks	+26 lines, -49 lines	0 comments	Download
M	test/browser/elemHideEmulation.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	test/domainRestrictions.js	View	7 chunks	+44 lines, -45 lines	0 comments	Download
M	test/elemHideEmulation.js	View	1 chunk	+13 lines, -13 lines	0 comments	Download
M	test/filterClasses.js	View	3 chunks	+30 lines, -33 lines	3 comments	Download
M	test/filterListener.js	View	2 chunks	+13 lines, -13 lines	0 comments	Download
M	test/filterStorage.js	View	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sebastian Noack

https://codereview.adblockplus.org/29453590/diff/29453591/test/filterClasses.js File test/filterClasses.js (left): https://codereview.adblockplus.org/29453590/diff/29453591/test/filterClasses.js#oldcode229 test/filterClasses.js:229: let filterText = domains + "##[-abp-properties='abc']"; Didn't we plan ...

June 1, 2017, 2:15 p.m. (2017-06-01 14:15:38 UTC) #3

Wladimir Palant

June 1, 2017, 2:30 p.m. (2017-06-01 14:30:23 UTC) #4

Sebastian Noack

June 1, 2017, 2:36 p.m. (2017-06-01 14:36:43 UTC) #5

https://codereview.adblockplus.org/29453590/diff/29453591/test/filterClasses.js
File test/filterClasses.js (left):

https://codereview.adblockplus.org/29453590/diff/29453591/test/filterClasses....
test/filterClasses.js:229: let filterText = domains +
"##[-abp-properties='abc']";
On 2017/06/01 14:30:23, Wladimir Palant wrote:
> On 2017/06/01 14:15:37, Sebastian Noack wrote:
> > Didn't we plan to keep supporting this syntax (in addition) for backwards
> > compatibility?
> 
> We do, for some limited time. But it makes little sense to keep testing legacy
> syntax all over the place - this syntax is tested in one place, that's
> sufficient.

I guess, if it is still tested in one place, at least, that might be good
enough. LGTM.

Expand All Messages | Collapse All Messages