Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/components/_cards.scss

Issue 29453600: Issue 4961 - Fix card group field alignment on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Restructure card markup and fixes Created June 13, 2017, 4:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/components/_cards.scss
===================================================================
--- a/static/scss/components/_cards.scss
+++ b/static/scss/components/_cards.scss
@@ -26,16 +26,26 @@
.card %headings
{
@extend h3;
height: $md + $sm;
margin: $sm 0 $sm 0;
}
+.card article .card-heading
juliandoucette 2017/06/16 19:39:16 Why article?
ire 2017/06/21 07:47:57 I was selecting the cards on the `pages/committee/
+{
+ height: auto;
+
+ @media (min-width: 700px)
juliandoucette 2017/06/16 19:39:16 Why 700?
ire 2017/06/21 07:47:57 Sorry, this was supposed to be the $tablet-breakpo
+ {
+ height: 120px;
+ }
+}
+
.card-icon
{
margin: $sm 0;
}
.center .card-icon
{
margin: $lg - $sm 0 $md 0;
@@ -131,8 +141,32 @@
text-decoration: none;
color: $primary-fg;
}
.card.list a%active
{
color: $accent;
}
+
+@supports (display: grid)
+{
+
+ .group .card
juliandoucette 2017/06/16 19:39:16 I think anything .group should go in _group.scss.
ire 2017/06/21 07:47:57 Acknowledged.
+ {
+ width: 100%;
+ grid-template-rows: auto 1fr auto;
+ }
+
+ .group .card .card-summary
+ {
+ @media all
juliandoucette 2017/06/16 19:39:17 Why @media all?
ire 2017/06/21 07:47:58 This is to override the various media queries that
+ {
+ height: auto;
+ }
+ }
+
+ .card-footer .m-t-md
+ {
+ margin-top: 0 !important;
ire 2017/06/13 16:51:23 This is to remove the large top margin that's on t
juliandoucette 2017/06/16 19:39:16 Perhaps this should go in includes/solutions/style
ire 2017/06/21 07:47:57 Okay I will move it then
+ }
+
+}

Powered by Google App Engine
This is Rietveld