Issue 29453616: Issue 5286 - Update to use libadblockplus rev. b88d098aeab5

Issue 29453616: Issue 5286 - Update to use libadblockplus rev. b88d098aeab5 (Closed)

Created:
June 1, 2017, 1:41 p.m. by sergei

Modified:
June 2, 2017, 1:54 p.m.

Reviewers:
René Jeschke, anton, diegocarloslima, jens

CC:
Felix Dahlke

Base URL:
github.com:abby-sergz/libadblockplus-android.git

Visibility:
Public.

Patch Set 2 : address comments #

Patch Set 3 : add missed dependencies #

Created: June 2, 2017, 1:45 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -28 lines)			Patch
M	dependencies	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	libadblockplus-android/jni/JniFilterEngine.cpp	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download
M	libadblockplus-android/jni/JniJsEngine.cpp	View		3 chunks	+1 line, -14 lines	0 comments	Download
M	libadblockplus-android/jni/JniWebRequest.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java	View		2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

sergei

https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-android/jni/JniFilterEngine.cpp File libadblockplus-android/jni/JniFilterEngine.cpp (right): https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-android/jni/JniFilterEngine.cpp#newcode67 libadblockplus-android/jni/JniFilterEngine.cpp:67: std::thread([callback, allowedConnectionType, doneCallback] Detached thread is still a hack ...

June 1, 2017, 2:41 p.m. (2017-06-01 14:41:58 UTC) #2

anton

https://codereview.adblockplus.org/29453616/diff/29453617/dependencies File dependencies (right): https://codereview.adblockplus.org/29453616/diff/29453617/dependencies#newcode4 dependencies:4: libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg:298e5ae02644 git:f6102eab8d61fa706b4cd43ec265eb40ce9dc819 why not use brief ...

June 2, 2017, 6:55 a.m. (2017-06-02 06:55:23 UTC) #3

sergei

June 2, 2017, 7:32 a.m. (2017-06-02 07:32:44 UTC) #4

anton

June 2, 2017, 7:43 a.m. (2017-06-02 07:43:09 UTC) #5

On 2017/06/02 07:32:44, sergei wrote:
> https://codereview.adblockplus.org/29453616/diff/29453617/dependencies
> File dependencies (right):
> 
>
https://codereview.adblockplus.org/29453616/diff/29453617/dependencies#newcode4
> dependencies:4: libadblockplus-android/jni/libadblockplus-binaries =
> libadblockplus-binaries hg:298e5ae02644
> git:f6102eab8d61fa706b4cd43ec265eb40ce9dc819
> On 2017/06/02 06:55:23, anton wrote:
> > why not use brief git revision like you suggested?
> 
> I had not suggested a short version because I find it unreliable and more
> difficult to use.
> 
>
https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-andr...
> File libadblockplus-android/jni/JniFilterEngine.cpp (right):
> 
>
https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-andr...
> libadblockplus-android/jni/JniFilterEngine.cpp:65: if
(allowedConnectionTypeArg)
> On 2017/06/02 06:55:23, anton wrote:
> > "{" required
> 
> Done.
> 
>
https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-andr...
> libadblockplus-android/jni/JniFilterEngine.cpp:67: std::thread([callback,
> allowedConnectionType, doneCallback]
> On 2017/06/02 06:55:23, anton wrote:
> > "}" required
> 
> Done.
> 
>
https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-andr...
> File libadblockplus-android/jni/JniWebRequest.cpp (right):
> 
>
https://codereview.adblockplus.org/29453616/diff/29453617/libadblockplus-andr...
> libadblockplus-android/jni/JniWebRequest.cpp:58: delete
> JniLongToTypePtr<AdblockPlus::WebRequestPtr>(ptr);
> On 2017/06/02 06:55:23, anton wrote:
> > don't we have to cast it to WebRequestSharedPtr? (see Ctor)
> 
> Good catch.

LGTM

Expand All Messages | Collapse All Messages