Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 29458572: Issue 5301 - Edge prepends extension path to URL when using tabs.create (Closed)
Patch Set: Created June 7, 2017, 11:58 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -701,7 +701,10 @@
{
chrome.windows.getLastFocused(win =>
{
- let optionsUrl = chrome.extension.getURL("options.html");
+ // NOTE: we expect this else branch to run only on Edge.
Sebastian Noack 2017/06/07 12:05:25 Well, if we should ever merge this upstream it wil
Oleksandr 2017/06/07 12:09:29 From what I understand only Edge does not support
+ // We are not using extension.getURL here because of the Edge issue:
+ // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
+ let optionsUrl = "options.html";
let queryInfo = {url: optionsUrl};
// extension pages can't be accessed in incognito windows. In order to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld