Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: inject.preload.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Handle webRequest.ResourceType (#5321) and RTCPeerConnection.generateCertificate, address comments Created June 15, 2017, 11:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: inject.preload.js
===================================================================
--- a/inject.preload.js
+++ b/inject.preload.js
@@ -375,8 +375,10 @@
WrappedRTCPeerConnection.prototype = RealRTCPeerConnection.prototype;
let boundWrappedRTCPeerConnection = WrappedRTCPeerConnection.bind();
- copyProperties(RealRTCPeerConnection, boundWrappedRTCPeerConnection,
- ["generateCertificate", "name", "prototype"]);
+ // NOTE: Edge does not support generateCertificate
Sebastian Noack 2017/06/19 11:07:02 But what is about the other properties copied here
kzar 2017/06/19 14:13:38 Yea, this is not good. Please instead modify the c
Oleksandr 2017/06/21 23:38:35 Done.
+ if ("generateCertificate" in RealRTCPeerConnection)
+ copyProperties(RealRTCPeerConnection, boundWrappedRTCPeerConnection,
+ ["generateCertificate", "name", "prototype"]);
RealRTCPeerConnection.prototype.constructor = boundWrappedRTCPeerConnection;
if ("RTCPeerConnection" in window)

Powered by Google App Engine
This is Rietveld