Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29458635: Noissue - Specify Firefox builds in the README (Closed)

Created:
June 7, 2017, 4:15 p.m. by Sebastian Noack
Modified:
June 12, 2017, 12:52 p.m.
Reviewers:
kzar, Wladimir Palant
CC:
Oleksandr
Visibility:
Public.

Description

Noissue - Specify Firefox builds in the README

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Patch Set 3 : Made about:Debugging italic for consistency #

Total comments: 2

Patch Set 4 : Removed redundant comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M README.md View 1 2 3 2 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
June 7, 2017, 4:17 p.m. (2017-06-07 16:17:45 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29458635/diff/29458636/README.md File README.md (right): https://codereview.adblockplus.org/29458635/diff/29458636/README.md#newcode12 README.md:12: deprecated [Add-on SDK](https://developer.mozilla.org/en-US/Add-ons/SDK), It's not based on the Add-on ...
June 7, 2017, 7:54 p.m. (2017-06-07 19:54:07 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29458635/diff/29458636/README.md File README.md (right): https://codereview.adblockplus.org/29458635/diff/29458636/README.md#newcode12 README.md:12: deprecated [Add-on SDK](https://developer.mozilla.org/en-US/Add-ons/SDK), On 2017/06/07 19:54:07, Wladimir Palant wrote: ...
June 8, 2017, 1:37 p.m. (2017-06-08 13:37:01 UTC) #3
kzar
LGTM
June 8, 2017, 2:59 p.m. (2017-06-08 14:59:23 UTC) #4
Wladimir Palant
LGTM with one nit below. https://codereview.adblockplus.org/29458635/diff/29459592/README.md File README.md (right): https://codereview.adblockplus.org/29458635/diff/29459592/README.md#newcode11 README.md:11: The source code of ...
June 12, 2017, 7:52 a.m. (2017-06-12 07:52:34 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29458635/diff/29459592/README.md File README.md (right): https://codereview.adblockplus.org/29458635/diff/29459592/README.md#newcode11 README.md:11: The source code of the legacy Adblock Plus extension, ...
June 12, 2017, 12:49 p.m. (2017-06-12 12:49:08 UTC) #6
kzar
June 12, 2017, 12:50 p.m. (2017-06-12 12:50:49 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld