Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29459615: Issue 5194 - Remove Tracking Protection from Private Browsing (Closed)

Created:
June 8, 2017, 7:23 p.m. by diegocarloslima
Modified:
June 12, 2017, 2:31 p.m.
Reviewers:
anton, Felix Dahlke
CC:
jens, René Jeschke
Visibility:
Public.

Description

Issue 5194 - Remove Tracking Protection from Private Browsing

Patch Set 1 #

Patch Set 2 : Removing tracking link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M mobile/android/base/BrowserApp.java View 1 chunk +6 lines, -0 lines 0 comments Download
M mobile/android/base/widget/ContentSecurityDoorHanger.java View 1 chunk +3 lines, -1 line 0 comments Download
M mobile/android/chrome/content/aboutPrivateBrowsing.xhtml View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
diegocarloslima
Changed the message in the private mode page, removing the tracking protection parts. Also, added ...
June 8, 2017, 7:34 p.m. (2017-06-08 19:34:19 UTC) #1
anton
On 2017/06/08 19:34:19, diegocarloslima wrote: > Changed the message in the private mode page, removing ...
June 9, 2017, 5:40 a.m. (2017-06-09 05:40:33 UTC) #2
Felix Dahlke
LGTM
June 9, 2017, 6:23 a.m. (2017-06-09 06:23:09 UTC) #3
Felix Dahlke
June 12, 2017, 1:45 p.m. (2017-06-12 13:45:02 UTC) #4
New patch set is LGTM as well.

Powered by Google App Engine
This is Rietveld