Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(973)

Issue 29459615: Issue 5194 - Remove Tracking Protection from Private Browsing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by diegocarloslima
Modified:
2 years, 5 months ago
Reviewers:
Felix Dahlke, anton
CC:
jens, René Jeschke
Visibility:
Public.

Description

Issue 5194 - Remove Tracking Protection from Private Browsing

Patch Set 1 #

Patch Set 2 : Removing tracking link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M mobile/android/base/BrowserApp.java View 1 chunk +6 lines, -0 lines 0 comments Download
M mobile/android/base/widget/ContentSecurityDoorHanger.java View 1 chunk +3 lines, -1 line 0 comments Download
M mobile/android/chrome/content/aboutPrivateBrowsing.xhtml View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
diegocarloslima
Changed the message in the private mode page, removing the tracking protection parts. Also, added ...
2 years, 5 months ago (2017-06-08 19:34:19 UTC) #1
anton
On 2017/06/08 19:34:19, diegocarloslima wrote: > Changed the message in the private mode page, removing ...
2 years, 5 months ago (2017-06-09 05:40:33 UTC) #2
Felix Dahlke
LGTM
2 years, 5 months ago (2017-06-09 06:23:09 UTC) #3
Felix Dahlke
2 years, 5 months ago (2017-06-12 13:45:02 UTC) #4
New patch set is LGTM as well.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5