Noissue - Remove DOMContentLoaded listeners after they've fired

Noissue - Remove DOMContentLoaded listeners after they've fired

[kzar, 2017-06-09 13:26:46]

Patch Set 1

I noticed these whilst investigating the possible memory leak in #5291. I'm not
sure they're related so I've labelled the change as a Noissue.

[Sebastian Noack, 2017-07-05 16:42:18]

Is there any indication, that this reduces memory usage notably? A single
listener would only cause a significant memory leak if there are huge amount of
data (e.g. a large array) that is referenced by the listener function's closure.
Moreover, since this is a oneshot event, a smart browser implementation would
automatically remove the listener when it won't be called anymore.

[kzar, 2017-07-06 11:13:59]

On 2017/07/05 16:42:18, Sebastian Noack wrote:
> Is there any indication, that this reduces memory usage notably? A single
> listener would only cause a significant memory leak if there are huge amount
of
> data (e.g. a large array) that is referenced by the listener function's
closure.
> Moreover, since this is a oneshot event, a smart browser implementation would
> automatically remove the listener when it won't be called anymore.

No indication that it helped, but I couldn't reliably reproduce the memory leak.

[Sebastian Noack, 2017-08-18 10:41:42]

NO LGTM, given the lack of evidence that this change has any (positive) effect.

[Sebastian Noack, 2017-08-18 10:42:16]

On 2017/08/18 10:41:42, Sebastian Noack wrote:
> NO LGTM

*NOT LGTM