Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29463558: Issue 5300 - Add feature detection for object_subrequest (Closed)

Created:
June 12, 2017, 9:51 a.m. by Jon Sonesen
Modified:
June 13, 2017, 6:49 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 5300 - Add feature detection for object_subrequest

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/requestBlocker.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Jon Sonesen
June 12, 2017, 9:51 a.m. (2017-06-12 09:51:49 UTC) #1
Jon Sonesen
Not sure if there are more changes need down the code path I grepped around ...
June 12, 2017, 9:53 a.m. (2017-06-12 09:53:17 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29463558/diff/29463559/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29463558/diff/29463559/lib/requestBlocker.js#newcode35 lib/requestBlocker.js:35: Nit: The extra blank line added here is redundant.
June 12, 2017, 12:20 p.m. (2017-06-12 12:20:43 UTC) #3
Jon Sonesen
https://codereview.adblockplus.org/29463558/diff/29463559/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29463558/diff/29463559/lib/requestBlocker.js#newcode35 lib/requestBlocker.js:35: On 2017/06/12 12:20:43, Sebastian Noack wrote: > Nit: The ...
June 12, 2017, 3:37 p.m. (2017-06-12 15:37:48 UTC) #4
Sebastian Noack
June 12, 2017, 3:40 p.m. (2017-06-12 15:40:07 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld