Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29464703: Issue 5313 - Make error reporting more robust. (Closed)

Created:
June 14, 2017, 2:50 a.m. by hub
Modified:
June 19, 2017, 1:45 p.m.
Reviewers:
Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5313 - Make error reporting more robust.

Patch Set 1 #

Patch Set 2 : Also fixed a comment about parseSelector() that was wrong. #

Total comments: 4

Patch Set 3 : addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -67 lines) Patch
M chrome/content/elemHideEmulation.js View 1 2 4 chunks +59 lines, -67 lines 0 comments Download

Messages

Total messages: 5
hub
June 14, 2017, 2:50 a.m. (2017-06-14 02:50:11 UTC) #1
hub
The most elegant solution I found was to make parseSelector a member of elemHideEmulation as ...
June 14, 2017, 8:59 p.m. (2017-06-14 20:59:33 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29464703/diff/29464706/chrome/content/elemHideEmulation.js File chrome/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29464703/diff/29464706/chrome/content/elemHideEmulation.js#newcode311 chrome/content/elemHideEmulation.js:311: `selector ${selector}, ` + Nit: There should be no ...
June 19, 2017, 11:22 a.m. (2017-06-19 11:22:37 UTC) #3
hub
updated patch https://codereview.adblockplus.org/29464703/diff/29464706/chrome/content/elemHideEmulation.js File chrome/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29464703/diff/29464706/chrome/content/elemHideEmulation.js#newcode311 chrome/content/elemHideEmulation.js:311: `selector ${selector}, ` + On 2017/06/19 11:22:37, ...
June 19, 2017, 1:24 p.m. (2017-06-19 13:24:42 UTC) #4
Wladimir Palant
June 19, 2017, 1:43 p.m. (2017-06-19 13:43:14 UTC) #5
LGTM, much better this way

Powered by Google App Engine
This is Rietveld