Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29470687: Issue 5344 - Element hiding emulation exceptions (Closed)

Created:
June 21, 2017, 6:50 p.m. by hub
Modified:
July 5, 2017, 1:10 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5344 - Element hiding emulation exceptions

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -12 lines) Patch
M lib/elemHide.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/filterClasses.js View 4 chunks +44 lines, -6 lines 0 comments Download
M test/filterClasses.js View 5 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6
hub
June 21, 2017, 6:50 p.m. (2017-06-21 18:50:34 UTC) #1
hub
I choose to use #^# to specify an exception, to make our life simpler, instead ...
June 21, 2017, 6:54 p.m. (2017-06-21 18:54:04 UTC) #2
Sebastian Noack
Thanks a lot for addressing this. On 2017/06/21 18:54:04, hub wrote: > I choose to ...
June 22, 2017, 3:57 p.m. (2017-06-22 15:57:55 UTC) #3
Wladimir Palant
I don't really see the point of this change. It seems that https://issues.adblockplus.org/ticket/5344 is simply ...
July 5, 2017, 12:47 p.m. (2017-07-05 12:47:32 UTC) #4
Sebastian Noack
I'm adding Arthur to the discussion. He was the one who requested this feature.
July 5, 2017, 12:52 p.m. (2017-07-05 12:52:22 UTC) #5
arthur
July 5, 2017, 1:05 p.m. (2017-07-05 13:05:36 UTC) #6
On 2017/07/05 12:52:22, Sebastian Noack wrote:
> I'm adding Arthur to the discussion. He was the one who requested this
feature.

My bad. :( I think I didn't actually try to use the regular exception syntax.

Powered by Google App Engine
This is Rietveld