Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1218)

Issue 29479601: Issue 5273 - Automatically update bundled lists (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by jens
Modified:
1 year, 11 months ago
Reviewers:
anton, diegocarloslima
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 5273 - Automatically update bundled lists

Patch Set 1 #

Total comments: 4

Patch Set 2 : Formatting and output when lists were updated #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M adblockplussbrowser/build.gradle View 1 1 chunk +16 lines, -0 lines 0 comments Download
M build.gradle View 1 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 10
jens
2 years ago (2017-07-04 12:52:43 UTC) #1
anton
On 2017/07/04 12:52:43, jens wrote: LGTM taking into account minor notes
2 years ago (2017-07-06 06:40:18 UTC) #2
anton
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle File adblockplussbrowser/build.gradle (right): https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle#newcode1 adblockplussbrowser/build.gradle:1: this change (new line) is not required https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle#newcode42 adblockplussbrowser/build.gradle:42: ...
2 years ago (2017-07-06 06:40:25 UTC) #3
jens
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle File adblockplussbrowser/build.gradle (right): https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle#newcode1 adblockplussbrowser/build.gradle:1: On 2017/07/06 06:40:24, anton wrote: > this change (new ...
2 years ago (2017-07-06 07:54:16 UTC) #4
jens
2 years ago (2017-07-07 07:09:55 UTC) #5
jens
2 years ago (2017-07-07 07:33:20 UTC) #6
diegocarloslima
https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle File build.gradle (right): https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle#newcode27 build.gradle:27: exceptionRulesFilePath = file('adblockplussbrowser/res/raw/exceptionrules.txt').absolutePath Do you think that these vars ...
2 years ago (2017-07-07 12:11:09 UTC) #7
jens
https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle File build.gradle (right): https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle#newcode27 build.gradle:27: exceptionRulesFilePath = file('adblockplussbrowser/res/raw/exceptionrules.txt').absolutePath On 2017/07/07 12:11:09, diegocarloslima wrote: > ...
2 years ago (2017-07-07 12:34:44 UTC) #8
anton
On 2017/07/06 07:54:16, jens wrote: > https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle > File adblockplussbrowser/build.gradle (right): > > https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser/build.gradle#newcode1 > ...
2 years ago (2017-07-07 13:04:29 UTC) #9
diegocarloslima
2 years ago (2017-07-07 13:20:21 UTC) #10
On 2017/07/07 13:04:29, anton wrote:
> On 2017/07/06 07:54:16, jens wrote:
> >
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> > File adblockplussbrowser/build.gradle (right):
> > 
> >
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> > adblockplussbrowser/build.gradle:1: 
> > On 2017/07/06 06:40:24, anton wrote:
> > > this change (new line) is not required
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> > adblockplussbrowser/build.gradle:42: updateBundledLists()
> > On 2017/07/06 06:40:24, anton wrote:
> > > it would be great to output that the lists are updated to know exact
> date/time
> > > of bundled files.
> > 
> > Good idea, I will add a console output message.
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5