Issue 5273 - Automatically update bundled lists

Issue 5273 - Automatically update bundled lists

[anton, 2017-07-06 06:40:18]

On 2017/07/04 12:52:43, jens wrote:

LGTM taking into account minor notes

[anton, 2017-07-06 06:40:25]

https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
File adblockplussbrowser/build.gradle (right):

https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
adblockplussbrowser/build.gradle:1: 
this change (new line) is not required

https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
adblockplussbrowser/build.gradle:42: updateBundledLists()
it would be great to output that the lists are updated to know exact date/time
of bundled files.

[jens, 2017-07-06 07:54:16]

https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
File adblockplussbrowser/build.gradle (right):

https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
adblockplussbrowser/build.gradle:1: 
On 2017/07/06 06:40:24, anton wrote:
> this change (new line) is not required

Acknowledged.

https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
adblockplussbrowser/build.gradle:42: updateBundledLists()
On 2017/07/06 06:40:24, anton wrote:
> it would be great to output that the lists are updated to know exact date/time
> of bundled files.

Good idea, I will add a console output message.

[diegocarloslima, 2017-07-07 12:11:09]

https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle
File build.gradle (right):

https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle#newcode27
build.gradle:27: exceptionRulesFilePath =
file('adblockplussbrowser/res/raw/exceptionrules.txt').absolutePath
Do you think that these vars are going to be used more than once (i.e. in the
tests module)?  Because the idea of declaring vars here is just to avoid
inconsistency in the multiple places where they're used

[jens, 2017-07-07 12:34:44]

https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle
File build.gradle (right):

https://codereview.adblockplus.org/29479601/diff/29482557/build.gradle#newcode27
build.gradle:27: exceptionRulesFilePath =
file('adblockplussbrowser/res/raw/exceptionrules.txt').absolutePath
On 2017/07/07 12:11:09, diegocarloslima wrote:
> Do you think that these vars are going to be used more than once (i.e. in the
> tests module)?  Because the idea of declaring vars here is just to avoid
> inconsistency in the multiple places where they're used

Yeah exactly, I think the vars can be used for tests.

[anton, 2017-07-07 13:04:29]

On 2017/07/06 07:54:16, jens wrote:
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> File adblockplussbrowser/build.gradle (right):
> 
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> adblockplussbrowser/build.gradle:1: 
> On 2017/07/06 06:40:24, anton wrote:
> > this change (new line) is not required
> 
> Acknowledged.
> 
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> adblockplussbrowser/build.gradle:42: updateBundledLists()
> On 2017/07/06 06:40:24, anton wrote:
> > it would be great to output that the lists are updated to know exact
date/time
> > of bundled files.
> 
> Good idea, I will add a console output message.

LGTM

[diegocarloslima, 2017-07-07 13:20:21]

On 2017/07/07 13:04:29, anton wrote:
> On 2017/07/06 07:54:16, jens wrote:
> >
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> > File adblockplussbrowser/build.gradle (right):
> > 
> >
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> > adblockplussbrowser/build.gradle:1: 
> > On 2017/07/06 06:40:24, anton wrote:
> > > this change (new line) is not required
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29479601/diff/29479602/adblockplussbrowser...
> > adblockplussbrowser/build.gradle:42: updateBundledLists()
> > On 2017/07/06 06:40:24, anton wrote:
> > > it would be great to output that the lists are updated to know exact
> date/time
> > > of bundled files.
> > 
> > Good idea, I will add a console output message.
> 
> LGTM

LGTM