build.gradle - Issue 29479601: Issue 5273 - Automatically update bundled lists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: build.gradle

Issue 29479601: Issue 5273 - Automatically update bundled lists (Closed)

Left Patch Set: Created July 4, 2017, 12:50 p.m.

Right Patch Set: Formatting and output when lists were updated Created July 7, 2017, 7:57 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
(Both sides are equal)
1 buildscript {	1 buildscript {

2 repositories {	2 repositories {

3 jcenter()	3 jcenter()

4 }	4 }

5 dependencies {	5 dependencies {

6 classpath 'com.android.tools.build:gradle:2.3.1'	6 classpath 'com.android.tools.build:gradle:2.3.1'

7 }	7 }

8 }	8 }

9	9

10 allprojects {	10 allprojects {

11 repositories {	11 repositories {

12 jcenter()	12 jcenter()

13 }	13 }

14 }	14 }

15	15

16 ext {	16 ext {

17 minSdkVersion = 21	17 minSdkVersion = 21

18 targetSdkVersion = 25	18 targetSdkVersion = 25

19 compileSdkVersion = 25	19 compileSdkVersion = 25

20 buildToolsVersion = '25.0.3'	20 buildToolsVersion = '25.0.3'

21 androidSupportLibraryVersion = '25.3.1'	21 androidSupportLibraryVersion = '25.3.1'

22 sourceCompatibilityVersion = JavaVersion.VERSION_1_7	22 sourceCompatibilityVersion = JavaVersion.VERSION_1_7

23 targetCompatibilityVersion = JavaVersion.VERSION_1_7	23 targetCompatibilityVersion = JavaVersion.VERSION_1_7

24 easyListUpdateUrl = 'https://easylist-downloads.adblockplus.org/easylist.txt '	24 easyListUpdateUrl = 'https://easylist-downloads.adblockplus.org/easylist.txt '

25 exceptionRulesUpdateUrl = 'https://easylist-downloads.adblockplus.org/except ionrules.txt'	25 exceptionRulesUpdateUrl = 'https://easylist-downloads.adblockplus.org/except ionrules.txt'

26 easyListFilePath = file('adblockplussbrowser/res/raw/easylist.txt').absolute Path	26 easyListFilePath = file('adblockplussbrowser/res/raw/easylist.txt').absolute Path

27 exceptionRulesFilePath = file('adblockplussbrowser/res/raw/exceptionrules.tx t').absolutePath	27 exceptionRulesFilePath = file('adblockplussbrowser/res/raw/exceptionrules.tx t').absolutePath
	diegocarloslima 2017/07/07 12:11:09 Do you think that these vars are going to be used Do you think that these vars are going to be used more than once (i.e. in the tests module)? Because the idea of declaring vars here is just to avoid inconsistency in the multiple places where they're used jens 2017/07/07 12:34:44 Yeah exactly, I think the vars can be used for tes Show quoted text On 2017/07/07 12:11:09, diegocarloslima wrote: > Do you think that these vars are going to be used more than once (i.e. in the > tests module)? Because the idea of declaring vars here is just to avoid > inconsistency in the multiple places where they're used Yeah exactly, I think the vars can be used for tests.
28 }	28 }

LEFT	RIGHT