Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29479612: Issue 4978 - Include filters with special subscription (Closed)

Created:
July 4, 2017, 2:24 p.m. by Manish Jethani
Modified:
July 5, 2017, 12:05 p.m.
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockplusui/
Visibility:
Public.

Description

Issue 4978 - Include filters with special subscription

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M messageResponder.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
July 4, 2017, 2:24 p.m. (2017-07-04 14:24:55 UTC) #1
Manish Jethani
Patch Set 1 This is part of the fix. If it's a special subscription, we ...
July 4, 2017, 2:26 p.m. (2017-07-04 14:26:57 UTC) #2
Sebastian Noack
LGTM
July 5, 2017, 11:04 a.m. (2017-07-05 11:04:54 UTC) #3
Thomas Greiner
July 5, 2017, 11:29 a.m. (2017-07-05 11:29:39 UTC) #4
LGTM

Later on we should probably introduce some parameter to "subscriptions.get"
instead to indicate whether or not filters should be included. The reason for it
being that we'll also be looking at filters from downloadable subscriptions. But
for now this approach should be fine.

Powered by Google App Engine
This is Rietveld