Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29479615: Issue 4978 - Read special subscription filters directly in options page (Closed)

Created:
July 4, 2017, 2:33 p.m. by Manish Jethani
Modified:
July 17, 2017, 3:43 p.m.
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/29479612/

Patch Set 1 #

Patch Set 2 : Update adblockplusui dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M options.js View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
July 4, 2017, 2:33 p.m. (2017-07-04 14:33:11 UTC) #1
Manish Jethani
Patch Set 1 Based on https://codereview.adblockplus.org/29479612/ This avoid the asynchronous fetching so that we already ...
July 4, 2017, 2:35 p.m. (2017-07-04 14:35:04 UTC) #2
Sebastian Noack
Looks good to me. But I suppose we have to update the adblockplusui dependency first.
July 5, 2017, 11:05 a.m. (2017-07-05 11:05:47 UTC) #3
Thomas Greiner
LGTM
July 5, 2017, 11:30 a.m. (2017-07-05 11:30:57 UTC) #4
Manish Jethani
On 2017/07/05 11:05:47, Sebastian Noack wrote: > Looks good to me. But I suppose we ...
July 5, 2017, 11:34 a.m. (2017-07-05 11:34:13 UTC) #5
Manish Jethani
Patch Set 2: Update adblockplusui dependency
July 5, 2017, 12:02 p.m. (2017-07-05 12:02:41 UTC) #6
Sebastian Noack
LGTM, but please DO NOT PUSH these changes before Adblock Plus 1.12.3 for Chrome is ...
July 5, 2017, 12:21 p.m. (2017-07-05 12:21:20 UTC) #7
Manish Jethani
July 5, 2017, 12:22 p.m. (2017-07-05 12:22:28 UTC) #8
On 2017/07/05 12:21:20, Sebastian Noack wrote:
> LGTM, but please DO NOT PUSH these changes before Adblock Plus 1.12.3 for
Chrome
> is out, we are currently in code freeze.

Gotcha, thanks.

Powered by Google App Engine
This is Rietveld