Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/searchform.tmpl

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)
Patch Set: Created July 10, 2017, 4:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: includes/searchform.tmpl
===================================================================
new file mode 100644
--- /dev/null
+++ b/includes/searchform.tmpl
@@ -0,0 +1,7 @@
+<form id="searchform" action="">
juliandoucette 2017/07/14 14:11:29 You can fill in the action and make this work now
ire 2017/07/17 09:25:53 Done.
+ <label for="search" class="sr-only">Search Adblock Plus Help</label>
juliandoucette 2017/07/14 14:11:29 I'm not sure this is necessary considering the pla
ire 2017/07/17 09:25:53 I think the label is more important that the other
+ <input id="search" name="search" type="search" placeholder="Search Adblock Plus Help">
+ <button type="submit" aria-label="Search">
+ <img src="img/png/searchIcon.png" srcset="img/png/searchIcon.png, img/svg/searchIcon.svg 2x" alt="Search">
+ </button>
+</form>

Powered by Google App Engine
This is Rietveld