Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/components/_searchform.scss

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)
Patch Set: Fix svgs, Implement search, Show searchbar for no-js Created July 17, 2017, 9:24 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/components/_searchform.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/scss/components/_searchform.scss
@@ -0,0 +1,145 @@
+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
+
+#site-search
+{
+ clear: both;
+ width: 100%;
juliandoucette 2017/07/19 18:03:36 NIT: I think this width is unnecessary?
ire 2017/07/21 10:23:29 Done.
+
+ &:not(.open)
juliandoucette 2017/07/19 18:03:35 NIT: I think it may be clearer if we just make dis
ire 2017/07/21 10:23:28 Done.
+ {
+ display: none;
+ }
+
+ @media (min-width: $tablet-breakpoint)
+ {
+ clear: none;
+ width: auto;
+
+ &:not(.open)
+ {
+ display: block;
+ }
+ }
+}
+
+.no-js #site-search
+{
+ display: block;
+}
+
+// Product Website Link
+
+#product-website-link
+{
+ float: right;
+}
+
+#site-search.open #product-website-link,
+.no-js #product-website-link
juliandoucette 2017/07/19 18:03:35 I think this is misleading as .no-js #product-webs
ire 2017/07/21 10:23:28 I don't understand. `.no-js #product-website-link`
juliandoucette 2017/07/24 21:08:08 Acknowledged. I don't know what I was thinking :/
+{
+ float: none;
+
+ @media (min-width: $mobile-breakpoint)
+ {
+ float: right;
+ margin-top: 20px;
+ }
+
+ @media (min-width: $tablet-breakpoint)
+ {
+ margin-top: 0;
+ }
+}
+
+// Search Form
+
+#searchform
+{
+ display: inline-block;
+ position: relative;
+ overflow: hidden;
+ width: 100%;
+ height: $searchform-height;
+ border-radius: 3px;
+ color: $gray;
+ background: #fff;
+ line-height: 1;
+ vertical-align: middle;
juliandoucette 2017/07/19 18:03:36 Should every child of `.navbar` be vertical-align
ire 2017/07/21 10:23:28 No, considering my comment about .navbar also bein
+
+ @media (min-width: $mobile-breakpoint)
+ {
+ max-width: $searchform-width;
juliandoucette 2017/07/19 18:03:35 NIT/Suggest: $search-max-width
ire 2017/07/21 10:23:28 I'm not sure about this. On mobile, the search for
+ }
+}
+
+#site-search.open #searchform,
juliandoucette 2017/07/19 18:03:37 It seems like this should apply to a container of
ire 2017/07/21 10:23:27 The margin-top on both these elements, although th
+.no-js #searchform
+{
+ margin-top: 20px;
+
+ @media (min-width: $tablet-breakpoint)
+ {
+ margin-top: 0;
+ }
+}
+
+#searchform input
+{
+ width: 100%;
+ height: $searchform-height - 2px;
+ padding-right: $searchform-height + 5px;
+ padding-left: 10px;
+ border: 0;
+ font-family: $primary-font;
+ font-size: $small-font;
+}
+
+#searchform button
+{
+ position: absolute;
+ top: 0;
+ right: 0;
+ width: $searchform-height;
+ height: 100%;
+ border: 0;
+ background-color: transparent;
+}
+
+#searchform button img
+{
+ height: 15px;
+}
+
+html[dir="rtl"]
+{
+ #searchform input
+ {
+ padding-right: 10px;
+ padding-left: $searchform-height + 5px;
+ }
+
+ #searchform button
+ {
+ right: auto;
+ left: 0;
+ }
+
+ #product-website-link
+ {
+ float: left;
+ }
+}

Powered by Google App Engine
This is Rietveld