Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browser/elemHideEmulation.js

Issue 29485613: Noissue - Throw an error if the client code doesn't load (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created July 10, 2017, 8:40 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/elemHideEmulation.js
===================================================================
--- a/test/browser/elemHideEmulation.js
+++ b/test/browser/elemHideEmulation.js
@@ -89,27 +89,30 @@
}
function createPseudoElementWithStyle(element, pseudo, styleBlock)
{
insertStyleRule(`#${element.id}${pseudo} ${styleBlock}`);
}
// Will ensure the class ElemHideEmulation is loaded.
-// NOTE: if it never loads, this will probably hang.
-function loadElemHideEmulation()
+// Pass true when it calls itself.
+function loadElemHideEmulation(inside)
{
if (typeof ElemHideEmulation == "undefined")
{
+ if (inside)
+ return Promise.reject("Failed to load ElemHideEmulation.");
+
return loadScript(myUrl + "/../../../lib/common.js").then(() =>
{
return loadScript(myUrl + "/../../../chrome/content/elemHideEmulation.js");
}).then(() =>
{
- return loadElemHideEmulation();
+ return loadElemHideEmulation(true);
});
}
return Promise.resolve();
}
// Create a new ElemHideEmulation instance with @selectors.
function applyElemHideEmulation(selectors)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld