Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29485613: Noissue - Throw an error if the client code doesn't load (Closed)

Created:
July 10, 2017, 8:40 p.m. by hub
Modified:
July 11, 2017, 1:08 p.m.
Reviewers:
Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Throw an error if the client code doesn't load

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M test/browser/elemHideEmulation.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
hub
July 10, 2017, 8:40 p.m. (2017-07-10 20:40:26 UTC) #1
hub
Any errors in the test would cause it to hang... or timeout. Now we reject ...
July 10, 2017, 8:41 p.m. (2017-07-10 20:41:19 UTC) #2
Wladimir Palant
July 11, 2017, 10:35 a.m. (2017-07-11 10:35:48 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld