Issue 5404 - :-abp-properties() nested within :-abp-has() should work if the relevant selector refe…

Note that this change is based on top of the adblockpluschrome-1.13.3 branch

[kzar, 2017-07-11 10:51:45]

LGTM

[hub, 2017-07-11 17:19:34]

https://codereview.adblockplus.org/29486558/diff/29486559/test/browser/elemHi...
File test/browser/elemHideEmulation.js (left):

https://codereview.adblockplus.org/29486558/diff/29486559/test/browser/elemHi...
test/browser/elemHideEmulation.js:396: 
you are removing this test because it fails, but :-abp-has(> div.inside) is
meant to be valid.

I based the behaviour on this draft spec 
   https://drafts.csswg.org/selectors/#relational

With the following patch it works:

diff --git a/chrome/content/elemHideEmulation.js
b/chrome/content/elemHideEmulation.js
--- a/chrome/content/elemHideEmulation.js
+++ b/chrome/content/elemHideEmulation.js
@@ -184,16 +184,17 @@
    */
   *getSelectors(prefix, subtree, styles)
   {
     yield [prefix + this._selector, subtree];
   }
 };

 const incompletePrefixRegexp = /[\s>+~]$/;
+const relativeSelector = /^[\s>+~]/;

 function HasSelector(selectors)
 {
   this._innerSelectors = selectors;
 }

 HasSelector.prototype = {
   requiresHiding: true,
@@ -219,18 +220,22 @@
   {
     let actualPrefix = (!prefix || incompletePrefixRegexp.test(prefix)) ?
         prefix + "*" : prefix;
     let elements = subtree.querySelectorAll(actualPrefix);
     for (let element of elements)
     {
       let iter = evaluate(this._innerSelectors, 0, "", element, styles);
       for (let selector of iter)
+      {
+        if (relativeSelector.test(selector))
+          selector = ":scope" + selector;
         if (element.querySelector(selector))
           yield element;
+      }
     }
   }
 };

 function ContainsSelector(textContent)
 {
   this._text = textContent;
 }

[hub, 2017-08-07 14:28:21]

I filed this for that last comment
https://issues.adblockplus.org/ticket/5436

(and the associates review)

[hub, 2017-08-07 14:35:14]

LGTM

so we can get this on master (and have parity with the 1.13.3 branch) and move
forward with the improvements.