Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/layout/_footer.scss

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)
Patch Set: Rebased and updated Created Sept. 4, 2017, 8:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/layout/_footer.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/scss/layout/_footer.scss
@@ -0,0 +1,90 @@
+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
+
+#site-footer
+{
+ font-size: $small-font;
+}
+
+#site-footer .one-fourth
+{
+ margin-bottom: $sm;
+
+ @media (min-width: $phablet-breakpoint)
+ {
+ margin-bottom: 0;
+ }
+}
+
+#site-footer .three-fourths
juliandoucette 2017/09/06 17:48:22 NIT: This seems too general. We could conceivably
ire 2017/09/08 09:53:36 Done.
+{
+ @media (min-width: $phablet-breakpoint)
+ {
+ text-align: right;
+ }
+}
+
+[dir="rtl"] #site-footer .three-fourths
+{
+ @media (min-width: $phablet-breakpoint)
+ {
+ text-align: left;
+ }
+}
+
+#site-footer-nav
+{
+ @media (min-width: $tablet-breakpoint)
+ {
+ display: inline;
+ }
+}
+
+#site-footer-nav ul
juliandoucette 2017/09/06 17:48:22 NIT: Shouldn't we do this with a horizontal list u
ire 2017/09/08 09:53:36 Done.
+{
+ display: inline;
+ list-style: none;
+}
+
+[dir="rtl"] #site-footer-nav ul
+{
+ padding: 0;
+}
+
+#site-footer-nav li
+{
+ display: inline;
+ margin-right: $sm;
+ padding-right: $sm;
+ border-right: 1px solid $gray;
juliandoucette 2017/09/06 17:48:22 NIT: Why not border-right the first-child or borde
ire 2017/09/08 09:53:36 I did it this way because if we added another list
juliandoucette 2017/09/08 17:02:52 Good point.
+
+ &:last-child
+ {
+ margin-right: 0px;
+ padding-right: 0px;
+ border-right: 0px;
+ }
+
+ @media (min-width: $tablet-breakpoint)
+ {
+ &:last-child
+ {
+ margin-right: $sm;
+ padding-right: $sm;
+ border-right: 1px solid $gray;
+ }
+ }
+}

Powered by Google App Engine
This is Rietveld