Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/layout/_grid.scss

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)
Patch Set: Rebased and updated Created Sept. 4, 2017, 8:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/layout/_grid.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/scss/layout/_grid.scss
@@ -0,0 +1,55 @@
+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
+
+.column
+{
+ padding: 0;
juliandoucette 2017/09/06 17:48:22 Why eliminate the gutter width? Note: You didn't
ire 2017/09/08 09:53:36 In the case of the footer, the gutter isn't needed
juliandoucette 2017/09/08 17:02:53 I agree. But this does beg the question of why you
ire 2017/09/12 08:57:53 Most of the other styles are still valid. I didn't
+}
+
+@media(min-width: $phablet-breakpoint)
juliandoucette 2017/09/06 17:48:22 Note: It seems like we could make sizes conditiona
ire 2017/09/08 09:53:36 How would that work? In this case, the sizes thems
juliandoucette 2017/09/08 17:02:53 Good question. Conditionals aren't quite the way t
ire 2017/09/12 08:57:53 Thanks! I would like to update website-defaults i
+{
+ .one-half,
+ .one-third,
+ .two-thirds,
+ .one-fourth,
+ .three-fourths
+ {
+ width: 50%;
+ }
+}
+
+@media(min-width: $tablet-breakpoint)
+{
+ .one-third
+ {
+ width: 33.333333%;
+ }
+
+ .two-thirds
+ {
+ width: 66.666667%;
+ }
+
+ .one-fourth
+ {
+ width: 25%;
+ }
+
+ .three-fourths
+ {
+ width: 75%;
+ }
+}

Powered by Google App Engine
This is Rietveld