Issue 29488589: Issue 5411 - Undefined var MOZ_ANDROID_GCM_SENDERID

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29488589: Issue 5411 - Undefined var MOZ_ANDROID_GCM_SENDERID (Closed)

Created:
July 13, 2017, 3:50 p.m. by diegocarloslima

Modified:
Aug. 7, 2017, 9:36 p.m.

Reviewers:
anton, jens

CC:
René Jeschke, Felix Dahlke

Visibility:
Public.

Description

Issue 5411 - Undefined var MOZ_ANDROID_GCM_SENDERID

Patch Set 1 #

Total comments: 1

Created: July 13, 2017, 3:50 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	mobile/android/branding/adblockbrowser/configure.sh	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

diegocarloslima

https://codereview.adblockplus.org/29488589/diff/29488590/mobile/android/branding/adblockbrowser/configure.sh File mobile/android/branding/adblockbrowser/configure.sh (right): https://codereview.adblockplus.org/29488589/diff/29488590/mobile/android/branding/adblockbrowser/configure.sh#newcode11 mobile/android/branding/adblockbrowser/configure.sh:11: MOZ_ANDROID_GCM_SENDERID=0 I could also have fixed this by removing ...

July 13, 2017, 3:54 p.m. (2017-07-13 15:54:08 UTC) #1

anton

On 2017/07/13 15:54:08, diegocarloslima wrote: > https://codereview.adblockplus.org/29488589/diff/29488590/mobile/android/branding/adblockbrowser/configure.sh > File mobile/android/branding/adblockbrowser/configure.sh (right): > > https://codereview.adblockplus.org/29488589/diff/29488590/mobile/android/branding/adblockbrowser/configure.sh#newcode11 > ...

July 17, 2017, 11:05 a.m. (2017-07-17 11:05:13 UTC) #2

jens

July 25, 2017, 12:56 p.m. (2017-07-25 12:56:57 UTC) #3

On 2017/07/13 15:54:08, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29488589/diff/29488590/mobile/android/bran...
> File mobile/android/branding/adblockbrowser/configure.sh (right):
> 
>
https://codereview.adblockplus.org/29488589/diff/29488590/mobile/android/bran...
> mobile/android/branding/adblockbrowser/configure.sh:11:
> MOZ_ANDROID_GCM_SENDERID=0
> I could also have fixed this by removing the `pref("dom.push.serverURL",
>
"https://updates.push.services.mozilla.com/v1/gcm/@MOZ_ANDROID_GCM_SENDERID@");`
> line in mobile.js, but I think this approach is better because it doesn't
touch
> the upstream code

LGTM

Expand All Messages | Collapse All Messages