Issue 29492555: Issue 5283 - Combine other raw types with WebSocket and WebRTC when possible

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29492555: Issue 5283 - Combine other raw types with WebSocket and WebRTC when possible (Closed)

Created:
July 19, 2017, 10:26 a.m. by Manish Jethani

Modified:
July 19, 2017, 10:42 a.m.

Reviewers:
Sebastian Noack

CC:
kzar

Base URL:
https://hg.adblockplus.org/abp2blocklist

Visibility:
Public.

Description

Issue 5283 - Combine other raw types with WebSocket and WebRTC when possible The filter "foo$websocket,webrtc,xmlhttprequest" generates a single rule with a generic URL scheme, but the filter "foo$websocket,webrtc,ping" does not. After this change, all HTTP raw types are combined with WebSocket and WebRTC when possible. "foo$websocket,webrtc,ping" will also generate a single rule. Other than that, it's just slightly refactored code.

Patch Set 1 #

Created: July 19, 2017, 10:26 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -29 lines)			Patch
	M	lib/abp2blocklist.js	View		4 chunks	+31 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 The filter "foo$websocket,webrtc,xmlhttprequest" generates a single rule with a generic URL scheme, ...

July 19, 2017, 10:30 a.m. (2017-07-19 10:30:56 UTC) #2

LGTM

Expand All Messages | Collapse All Messages