Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29493562: Issue 5433 - move most of v8 related configuration from libadblockplus.gyp into v8.gypi (Closed)

Created:
July 20, 2017, 10:01 a.m. by sergei
Modified:
July 20, 2017, 9:02 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

#depends on https://codereview.adblockplus.org/29493555/

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -58 lines) Patch
M libadblockplus.gyp View 2 chunks +15 lines, -58 lines 2 comments Download
A v8.gypi View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sergei
https://codereview.adblockplus.org/29493562/diff/29493563/libadblockplus.gyp File libadblockplus.gyp (left): https://codereview.adblockplus.org/29493562/diff/29493563/libadblockplus.gyp#oldcode55 libadblockplus.gyp:55: 'third_party/v8', Here is a change, it turned out that ...
July 20, 2017, 10:23 a.m. (2017-07-20 10:23:01 UTC) #1
hub
July 20, 2017, 12:53 p.m. (2017-07-20 12:53:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld