Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29493566: Issue 5433 - add option to use prebuilt v8 (Closed)

Created:
July 20, 2017, 10:44 a.m. by sergei
Modified:
July 20, 2017, 9:01 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

#depends on https://codereview.adblockplus.org/29493562/

Patch Set 1 #

Total comments: 1

Patch Set 2 : update readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -20 lines) Patch
M Makefile View 4 chunks +24 lines, -7 lines 0 comments Download
M README.md View 1 1 chunk +18 lines, -0 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M v8.gypi View 2 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 8
sergei
https://codereview.adblockplus.org/29493566/diff/29493578/v8.gypi File v8.gypi (right): https://codereview.adblockplus.org/29493566/diff/29493578/v8.gypi#newcode33 v8.gypi:33: '<(libv8_lib_dir)/libv8_libplatform.a', For android it's required to specify .a files, ...
July 20, 2017, 12:09 p.m. (2017-07-20 12:09:05 UTC) #1
hub
LGTM
July 20, 2017, 12:55 p.m. (2017-07-20 12:55:35 UTC) #2
sergei
Forgot to add how to use it, commit message has been updated.
July 20, 2017, 1:23 p.m. (2017-07-20 13:23:22 UTC) #3
hub
On 2017/07/20 13:23:22, sergei wrote: > Forgot to add how to use it, commit message ...
July 20, 2017, 1:43 p.m. (2017-07-20 13:43:10 UTC) #4
sergei
On 2017/07/20 13:43:10, hub wrote: > On 2017/07/20 13:23:22, sergei wrote: > > Forgot to ...
July 20, 2017, 1:54 p.m. (2017-07-20 13:54:47 UTC) #5
hub
On 2017/07/20 13:54:47, sergei wrote: > On 2017/07/20 13:43:10, hub wrote: > > On 2017/07/20 ...
July 20, 2017, 4:12 p.m. (2017-07-20 16:12:34 UTC) #6
sergei
On 2017/07/20 16:12:34, hub wrote: > On 2017/07/20 13:54:47, sergei wrote: > > On 2017/07/20 ...
July 20, 2017, 8 p.m. (2017-07-20 20:00:28 UTC) #7
hub
July 20, 2017, 8:01 p.m. (2017-07-20 20:01:30 UTC) #8
Excellent !

LGTM

Powered by Google App Engine
This is Rietveld