Noissue - Fix setLinks related ESLint errors

common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 16 matching lines @@
 function getDocLink(link, callback)
 {
   ext.backgroundPage.sendMessage({
     type: "app.get",
     what: "doclink",
     link
   }, callback);
 }
 
 function setLinks(id, ...args)
+{

[kzar, 2017/07/24 09:10:02]

The diff here looks ugly, but really I just removed two spaces from the start of
every line.

[Thomas Greiner, 2017/07/24 10:26:18]

Acknowledged. Thanks for pointing that out.

+  let element = E(id);
+  if (!element)
   {
-    let element = E(id);
-    if (!element)
+    return;
+  }
+
+  let links = element.getElementsByTagName("a");
+
+  for (let i = 0; i < links.length; i++)
+  {
+    if (typeof args[i] == "string")
     {
-      return;
+      links[i].href = args[i];
+      links[i].setAttribute("target", "_blank");
     }
-
-    let links = element.getElementsByTagName("a");
-
-    for (let i = 0; i < links.length; i++)
+    else if (typeof args[i] == "function")
     {
-      if (typeof args[i] == "string")
-      {
-        links[i].href = args[i];
-        links[i].setAttribute("target", "_blank");
-      }
-      else if (typeof args[i] == "function")
-      {
-        links[i].href = "javascript:void(0);";
-        links[i].addEventListener("click", args[i], false);
-      }
+      links[i].href = "javascript:void(0);";
+      links[i].addEventListener("click", args[i], false);
     }
   }
+}
 
 function checkShareResource(url, callback)
 {
   ext.backgroundPage.sendMessage({
     type: "filters.blocked",
     url,
     requestType: "SCRIPT",
     docDomain: "adblockplus.org",
     thirdParty: true
   }, callback);
@@ skipping 100 matching lines @@
       window.removeEventListener("message", popupMessageListener);
     }
 
     iframe.removeEventListener("load", popupLoadListener);
   };
   iframe.addEventListener("load", popupLoadListener, false);
 
   iframe.src = url;
   glassPane.className = "visible";
 }