Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29496555: Noissue - Fix setLinks related ESLint errors (Closed)

Created:
July 24, 2017, 9:08 a.m. by kzar
Modified:
July 24, 2017, 10:47 a.m.
Reviewers:
Thomas Greiner
CC:
saroyanm
Visibility:
Public.

Description

Noissue - Fix setLinks related ESLint errors

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M common.js View 1 chunk +17 lines, -17 lines 2 comments Download
M firstRun.js View 1 chunk +1 line, -1 line 0 comments Download
M new-options.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
kzar
Patch Set 1 https://codereview.adblockplus.org/29496555/diff/29496556/common.js File common.js (right): https://codereview.adblockplus.org/29496555/diff/29496556/common.js#newcode37 common.js:37: { The diff here looks ugly, ...
July 24, 2017, 9:10 a.m. (2017-07-24 09:10:02 UTC) #1
Thomas Greiner
July 24, 2017, 10:26 a.m. (2017-07-24 10:26:18 UTC) #2
LGTM

https://codereview.adblockplus.org/29496555/diff/29496556/common.js
File common.js (right):

https://codereview.adblockplus.org/29496555/diff/29496556/common.js#newcode37
common.js:37: {
On 2017/07/24 09:10:02, kzar wrote:
> The diff here looks ugly, but really I just removed two spaces from the start
of
> every line.

Acknowledged. Thanks for pointing that out.

Powered by Google App Engine
This is Rietveld