Issue 5448 - Add content_security_policy to the manifest.json for Chrome-extensions

Issue 5448 - Add content_security_policy to the manifest.json for Chrome-extensions

[tlucas, 2017-07-24 12:24:38]

Patch Set 1

Added a section for content_security_policy into the jinja2 manifest template

[kzar, 2017-07-24 13:19:16]

(Moving Sebastian to Cc since he's away at the moment.)

Just to check have you tested the option works? (That the option gets populated
in the generated manifest correctly when specified in the metadata, that it
doesn't when it isn't and that Chrome accepts the built extension for
installation.)

If not I recommend typing

  ./build.py -t chrome devenv

and then taking a look at the unpacked extension inside devenv.chrome. Then if
you make sure the "Developer mode" option is checked in the extensions page
chrome://extensions there should be an option to load an unpacked extension.

https://codereview.adblockplus.org/29496582/diff/29496583/templates/manifest....
File templates/manifest.json.tmpl (right):

https://codereview.adblockplus.org/29496582/diff/29496583/templates/manifest....
templates/manifest.json.tmpl:120: {%- if metadata.has_option('general',
'content_security_policy') %}
Looking at the other options it seems the convention is to use camelCase for the
option names. So would you mind changing it to contentSecurityPolicy and
updating the issue description to reflect that too?

[tlucas, 2017-07-24 13:50:44]

Patch Set 2

Adhering to camelCase for option-names

On 2017/07/24 13:19:16, kzar wrote:
> (Moving Sebastian to Cc since he's away at the moment.)
> 
> Just to check have you tested the option works? (That the option gets
populated
> in the generated manifest correctly when specified in the metadata, that it
> doesn't when it isn't and that Chrome accepts the built extension for
> installation.)
> 

Yes, yes and yes.

https://codereview.adblockplus.org/29496582/diff/29496583/templates/manifest....
File templates/manifest.json.tmpl (right):

https://codereview.adblockplus.org/29496582/diff/29496583/templates/manifest....
templates/manifest.json.tmpl:120: {%- if metadata.has_option('general',
'content_security_policy') %}
On 2017/07/24 13:19:16, kzar wrote:
> Looking at the other options it seems the convention is to use camelCase for
the
> option names. So would you mind changing it to contentSecurityPolicy and
> updating the issue description to reflect that too?

Done.

[kzar, 2017-07-24 13:54:04]

LGTM