Issue 29496589: Noissue - workaround to reduce the probability of the race condition in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29496589: Noissue - workaround to reduce the probability of the race condition in tests (Closed)

Created:
July 24, 2017, 1:02 p.m. by sergei

Modified:
July 26, 2017, 5:16 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

The class (LazyFileSystem) is already removed but threads are still running and trying to access its members. Codereview: https://codereview.adblockplus.org/29496589

Patch Set 1 #

Created: July 24, 2017, 1:02 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	test/BaseJsTest.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hub

my big issue here is that we wait for some time instead of having synchronisation.

July 25, 2017, 6:07 p.m. (2017-07-25 18:07:40 UTC) #2

sergei

On 2017/07/25 18:07:40, hub wrote: > my big issue here is that we wait for ...

July 26, 2017, 12:31 p.m. (2017-07-26 12:31:06 UTC) #3

sergei

July 26, 2017, 5:16 p.m. (2017-07-26 17:16:18 UTC) #4

Message was sent while issue was closed.

On 2017/07/26 12:31:06, sergei wrote:
> On 2017/07/25 18:07:40, hub wrote:
> > my big issue here is that we wait for some time instead of having
> > synchronisation.
> 
> Yeah, I considered it as a temporary hack in order to get tests automatically
> running (I have updated travis-ci and appveyor config). Actually I think this
> change can wait because I am working on another change which will fix it by
> eliminating of race conditions, and I meanwhile I can simple bring this change
> each time, anyway I have to cherry-pick the commit with CI-configs.

It will be superseded by another changes.

Expand All Messages | Collapse All Messages