Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(384)

Issue 29497585: Issue 4514 - Font readability on acceptableads.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by ire
Modified:
2 years, 7 months ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 4514 - Font readability on acceptableads.com

Patch Set 1 #

Total comments: 3

Patch Set 2 : Increase spacing on fixed heights #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M includes/index/style.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M includes/solutions/style.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M static/css/main.css View 1 4 chunks +6 lines, -6 lines 0 comments Download
M static/scss/components/_cards.scss View 1 1 chunk +1 line, -1 line 0 comments Download
M static/scss/content/_buttons.scss View 1 1 chunk +3 lines, -3 lines 0 comments Download
M static/scss/content/_typography.scss View 1 chunk +1 line, -1 line 0 comments Download
M static/scss/layout/_footer.scss View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
ire
2 years, 7 months ago (2017-07-25 13:34:05 UTC) #1
ire
https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content/_buttons.scss File static/scss/content/_buttons.scss (right): https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content/_buttons.scss#newcode34 static/scss/content/_buttons.scss:34: line-height: $md + 10px; I'm not sure if it's ...
2 years, 7 months ago (2017-07-25 13:36:22 UTC) #2
juliandoucette
This causes the group items on the homepage to overflow on small screens. Can you ...
2 years, 7 months ago (2017-07-25 15:30:00 UTC) #3
ire
> This causes the group items on the homepage to overflow on small > screens. ...
2 years, 7 months ago (2017-07-26 08:44:22 UTC) #4
juliandoucette
LGTM Note: I think there's too much space in our cards now. But I'm happy ...
2 years, 7 months ago (2017-07-26 11:43:33 UTC) #5
ire
2 years, 7 months ago (2017-07-27 16:51:38 UTC) #6
On 2017/07/26 11:43:33, juliandoucette wrote:
> Note: I think there's too much space in our cards now. But I'm happy to
address
> that in a separate ticket.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5