Issue 4514 - Font readability on acceptableads.com

Issue 4514 - Font readability on acceptableads.com

[ire, 2017-07-25 13:36:22]

https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content...
File static/scss/content/_buttons.scss (right):

https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content...
static/scss/content/_buttons.scss:34: line-height: $md + 10px;
I'm not sure if it's better to represent this number the way it is, or just as
42px. Because we want this number to be relative to the height of the button,
minus 2px for alignment. I'm concerned that representing it as `$md + 10px`
doesn't make this clear

[juliandoucette, 2017-07-25 15:30:00]

This causes the group items on the homepage to overflow on small screens. Can
you please double check each manually set height to ensure that there is no
overflow when resizing?

https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content...
File static/scss/content/_buttons.scss (right):

https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content...
static/scss/content/_buttons.scss:34: line-height: $md + 10px;
On 2017/07/25 13:36:22, ire wrote:
> I'm not sure if it's better to represent this number the way it is, or just as
> 42px. Because we want this number to be relative to the height of the button,
> minus 2px for alignment. I'm concerned that representing it as `$md + 10px`
> doesn't make this clear

I think 42px is better.

[ire, 2017-07-26 08:44:22]

> This causes the group items on the homepage to overflow on small 
> screens. Can you please double check each manually set height to 
> ensure that there is no overflow when resizing?

Done.

https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content...
File static/scss/content/_buttons.scss (right):

https://codereview.adblockplus.org/29497585/diff/29497586/static/scss/content...
static/scss/content/_buttons.scss:34: line-height: $md + 10px;
On 2017/07/25 15:29:59, juliandoucette wrote:
> On 2017/07/25 13:36:22, ire wrote:
> > I'm not sure if it's better to represent this number the way it is, or just
as
> > 42px. Because we want this number to be relative to the height of the
button,
> > minus 2px for alignment. I'm concerned that representing it as `$md + 10px`
> > doesn't make this clear
> 
> I think 42px is better.

Done.

[juliandoucette, 2017-07-26 11:43:33]

LGTM

Note: I think there's too much space in our cards now. But I'm happy to address
that in a separate ticket.

[ire, 2017-07-27 16:51:38]

On 2017/07/26 11:43:33, juliandoucette wrote:
> Note: I think there's too much space in our cards now. But I'm happy to
address
> that in a separate ticket.

Acknowledged.