static/scss/content/_buttons.scss - Issue 29497585: Issue 4514 - Font readability on acceptableads.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: static/scss/content/_buttons.scss

Issue 29497585: Issue 4514 - Font readability on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com

Patch Set: Created July 25, 2017, 1:34 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: static/scss/content/_buttons.scss

===================================================================

--- a/static/scss/content/_buttons.scss

+++ b/static/scss/content/_buttons.scss

@@ -24,20 +24,20 @@

padding: 0 $sm;

cursor: pointer;

text-align: center;

white-space: nowrap;

text-decoration: none;

text-transform: uppercase;

border: 1px solid;

border-radius: 0px !important;

- font-size: $font-size-xs;

+ font-size: $font-size-md;

font-weight: 700;

- line-height: $md;

- height: 34px;

+ line-height: $md + 10px;

ire 2017/07/25 13:36:22 I'm not sure if it's better to represent this numb

juliandoucette 2017/07/25 15:29:59 I think 42px is better.

ire 2017/07/26 08:44:22 Done.

+ height: 44px;

}

@media(max-width: $mobile-breakpoint)

{

%buttons

{

display: block;

float: none;

« no previous file with comments | « static/css/main.css ('k') | static/scss/content/_typography.scss » ('j') | no next file with comments »