Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/DefaultWebRequest.h

Issue 29497591: Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 25, 2017, 2:31 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « libadblockplus.gyp ('k') | src/DefaultWebRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #ifndef ADBLOCK_PLUS_DEFAULT_WEB_REQUEST_H 18 #ifndef ADBLOCK_PLUS_DEFAULT_WEB_REQUEST_H
19 #define ADBLOCK_PLUS_DEFAULT_WEB_REQUEST_H 19 #define ADBLOCK_PLUS_DEFAULT_WEB_REQUEST_H
20 20
21 #include "WebRequest.h" 21 #include <AdblockPlus/IWebRequest.h>
22 22
23 namespace AdblockPlus 23 namespace AdblockPlus
24 { 24 {
25 /** 25 /**
26 * `WebRequest` implementation that uses `WinInet` on Windows and libcurl 26 * `WebRequest` implementation that uses `WinInet` on Windows and libcurl
27 * on other platforms. A dummy implementation that always reports failure is 27 * on other platforms. A dummy implementation that always reports failure is
28 * used if libcurl is not available. 28 * used if libcurl is not available.
29 */ 29 */
30 class DefaultWebRequestSync : public WebRequest 30 class DefaultWebRequestSync
31 { 31 {
32 public:
32 ServerResponse GET(const std::string& url, const HeaderList& requestHeaders) const; 33 ServerResponse GET(const std::string& url, const HeaderList& requestHeaders) const;
33 }; 34 };
34 35
35 class DefaultWebRequest : public IWebRequest 36 class DefaultWebRequest : public IWebRequest
36 { 37 {
37 public: 38 public:
38 explicit DefaultWebRequest(const WebRequestSharedPtr& syncImpl); 39 explicit DefaultWebRequest(std::unique_ptr<DefaultWebRequestSync>&& syncImpl );
39 ~DefaultWebRequest(); 40 ~DefaultWebRequest();
40 41
41 void GET(const std::string& url, const HeaderList& requestHeaders, const Get Callback& getCallback) override; 42 void GET(const std::string& url, const HeaderList& requestHeaders, const Get Callback& getCallback) override;
42 private: 43 private:
43 WebRequestSharedPtr syncImpl; 44 std::unique_ptr<DefaultWebRequestSync> syncImpl;
44 }; 45 };
45 } 46 }
46 47
47 #endif 48 #endif
OLDNEW
« no previous file with comments | « libadblockplus.gyp ('k') | src/DefaultWebRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld