Issue 29497591: Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29497591: Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest (Closed)

Created:
July 25, 2017, 2:31 p.m. by sergei

Modified:
July 26, 2017, 1:12 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Created: July 25, 2017, 2:31 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -209 lines)			Patch
M	include/AdblockPlus.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	include/AdblockPlus/DefaultWebRequest.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	include/AdblockPlus/JsEngine.h	View	3 chunks	+1 line, -10 lines	0 comments	Download
D	include/AdblockPlus/WebRequest.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	libadblockplus.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	src/DefaultWebRequest.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/DefaultWebRequest.cpp	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/DefaultWebRequestCurl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/DefaultWebRequestDummy.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/DefaultWebRequestWinInet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/JsEngine.cpp	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	src/WebRequestJsObject.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	test/Notification.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	test/WebRequest.cpp	View	10 chunks	+66 lines, -65 lines	0 comments	Download

Total messages: 2

LGTM