Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <AdblockPlus.h>
 #include "GlobalJsObject.h"
 #include "JsContext.h"
 #include "JsError.h"
 #include "Utils.h"
 #include "DefaultTimer.h"
+#include "DefaultWebRequest.h"
 #include <libplatform/libplatform.h>
 
 namespace
 {
   v8::Handle<v8::Script> CompileScript(v8::Isolate* isolate,
     const std::string& source, const std::string& filename)
   {
     using AdblockPlus::Utils::ToV8String;
     const v8::Handle<v8::String> v8Source = ToV8String(isolate, source);
     if (filename.length())
@@ skipping 44 matching lines @@
   return TimerPtr(new DefaultTimer());
 }
 
 FileSystemPtr AdblockPlus::CreateDefaultFileSystem()
 {
   return FileSystemPtr(new DefaultFileSystem(std::make_shared<DefaultFileSystemSync>()));
 }
 
 WebRequestPtr AdblockPlus::CreateDefaultWebRequest()
 {
-  return WebRequestPtr(new DefaultWebRequest(std::make_shared<DefaultWebRequestSync>()));
+  return WebRequestPtr(new DefaultWebRequest(std::unique_ptr<DefaultWebRequestSync>(new DefaultWebRequestSync())));
 }
 
 AdblockPlus::ScopedV8Isolate::ScopedV8Isolate()
 {
   V8Initializer::Init();
   v8::Isolate::CreateParams isolateParams;
   isolateParams.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator();
   isolate = v8::Isolate::New(isolateParams);
 }
 
@@ skipping 226 matching lines @@
 }
 
 void AdblockPlus::JsEngine::SetFileSystem(const AdblockPlus::FileSystemSyncPtr& val)
 {
   if (!val)
     throw std::runtime_error("FileSystem cannot be null");
 
   fileSystem.reset(new DefaultFileSystem(val));
 }
 
-void AdblockPlus::JsEngine::SetWebRequest(const AdblockPlus::WebRequestSharedPtr& val)
-{
-  if (!val)
-    throw std::runtime_error("WebRequest cannot be null");
-
-  webRequestLegacy = val;
-}
-
 AdblockPlus::LogSystemPtr AdblockPlus::JsEngine::GetLogSystem() const
 {
   return logSystem;
 }
 
 void AdblockPlus::JsEngine::SetLogSystem(const AdblockPlus::LogSystemPtr& val)
 {
   if (!val)
     throw std::runtime_error("LogSystem cannot be null");
 
   logSystem = val;
 }
 
 
 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               const AdblockPlus::JsValue& value)
 {
   auto global = GetGlobalObject();
   global.SetProperty(name, value);
 }