Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest

src/WebRequestJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 62 matching lines @@
     auto headersObject = jsEngine->NewObject();
     for (const auto& header : response.responseHeaders)
     {
       headersObject.SetProperty(header.first, header.second);
     }
     resultObject.SetProperty("responseHeaders", headersObject);
 
     webRequestParams[2].Call(resultObject);
   };
 
-  if (jsEngine->webRequestLegacy)
-  {
-    std::thread([jsEngine, url, headers, getCallback]
-    {
-      getCallback(jsEngine->webRequestLegacy->GET(url, headers));
-    }).detach();
-    return;
-  }
-
   jsEngine->webRequest->GET(url, headers, getCallback);
 }
 
 namespace
 {
   void GETCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
   {
     try
     {
       AdblockPlus::JsEngine::ScheduleWebRequest(arguments);
     } catch (const std::exception& e)
     {
       return AdblockPlus::Utils::ThrowExceptionInJS(arguments.GetIsolate(), e.what());
     }
   }
 }
 
 AdblockPlus::JsValue& AdblockPlus::WebRequestJsObject::Setup(
     AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj)
 {
   obj.SetProperty("GET", jsEngine.NewCallback(::GETCallback));
   return obj;
 }