Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest

test/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 45 matching lines @@
       filterEngine->SetShowNotificationCallback(
         [&retValue](Notification&& notification) {
           retValue.reset(new Notification(std::move(notification)));
         });
       filterEngine->ShowNextNotification(url);
       filterEngine->RemoveShowNotificationCallback();
       return retValue;
     }
   };
 
-  class MockWebRequest : public WebRequest
+  class MockWebRequest : public IWebRequest
   {
   public:
     std::string responseText;
     explicit MockWebRequest(const std::string& notification)
       : responseText(notification)
     {
     }
-    ServerResponse GET(const std::string& url,
-      const HeaderList& requestHeaders) const
+    void GET(const std::string& url, const HeaderList& requestHeaders,
+      const GetCallback& getCallback) override
     {
       if (url.find("/notification.json") == std::string::npos)
       {
-        return ServerResponse();
+        return;
       }
       ServerResponse serverResponse;
       serverResponse.status = IWebRequest::NS_OK;
       serverResponse.responseStatus = 200;
       serverResponse.responseText = responseText;
-      return serverResponse;
+      getCallback(serverResponse);
     }
   };
 
 #ifdef NotificationMockWebRequestTest_ENABLED
   class NotificationMockWebRequestTest : public BaseJsTest
   {
   protected:
     FilterEnginePtr filterEngine;
     bool isNotificationCallbackCalled;
     void SetUp()
@@ skipping 100 matching lines @@
 TEST_F(NotificationTest, Links)
 {
   AddNotification("{ id: 'id', links: ['link1', 'link2'] }");
   auto notification = PeekNotification();
   ASSERT_TRUE(notification);
   std::vector<std::string> notificationLinks = notification->GetLinks();
   ASSERT_EQ(2u, notificationLinks.size());
   EXPECT_EQ("link1", notificationLinks[0]);
   EXPECT_EQ("link2", notificationLinks[1]);
 }