Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 29497591: Issue 5180 - remove synchronous WebRequest interface and stop exposing of DefaultWebRequest (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 25, 2017, 2:31 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/DefaultWebRequest.h ('k') | include/AdblockPlus/WebRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
diff --git a/include/AdblockPlus/JsEngine.h b/include/AdblockPlus/JsEngine.h
index f7470ab84367b00e298c9038d92b21837fb08202..f4a3d3bb1a8c789b70750e7196ae570f38eebd53 100644
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -29,7 +29,7 @@
#include <AdblockPlus/LogSystem.h>
#include <AdblockPlus/FileSystem.h>
#include <AdblockPlus/JsValue.h>
-#include <AdblockPlus/WebRequest.h>
+#include <AdblockPlus/IWebRequest.h>
#include <AdblockPlus/ITimer.h>
namespace v8
@@ -277,14 +277,6 @@ namespace AdblockPlus
void SetFileSystem(const FileSystemSyncPtr& val);
/**
- * Sets the `WebRequest` implementation used for XMLHttpRequests.
- * Setting this is optional, the engine will use a `DefaultWebRequest`
- * instance by default, which might be sufficient.
- * @param The `WebRequest` instance to use.
- */
- void SetWebRequest(const WebRequestSharedPtr& val);
-
- /**
* @see `SetLogSystem()`.
*/
LogSystemPtr GetLogSystem() const;
@@ -338,7 +330,6 @@ namespace AdblockPlus
std::mutex jsWeakValuesListsMutex;
TimerPtr timer;
WebRequestPtr webRequest;
- WebRequestSharedPtr webRequestLegacy;
};
}
« no previous file with comments | « include/AdblockPlus/DefaultWebRequest.h ('k') | include/AdblockPlus/WebRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld