Noissue - don't throw a pointer to an exception in C++

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 147 matching lines @@
   {
     v8::Local<v8::Value> item = array->Get(i);
     result.push_back(JsValue(jsEngine, item));
   }
   return result;
 }
 
 std::vector<std::string> AdblockPlus::JsValue::GetOwnPropertyNames() const
 {
   if (!IsObject())
-    throw new std::runtime_error("Attempting to get propert list for a non-object");
+    throw std::runtime_error("Attempting to get propert list for a non-object");
 
   const JsContext context(*jsEngine);
   v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(UnwrapValue());
   JsValueList properties = JsValue(jsEngine, object->GetOwnPropertyNames()).AsList();
   std::vector<std::string> result;
   for (const auto& property : properties)
     result.push_back(property.AsString());
   return result;
 }
 
 
 AdblockPlus::JsValue AdblockPlus::JsValue::GetProperty(const std::string& name) const
 {
   if (!IsObject())
-    throw new std::runtime_error("Attempting to get property of a non-object");
+    throw std::runtime_error("Attempting to get property of a non-object");
 
   const JsContext context(*jsEngine);
   v8::Local<v8::String> property = Utils::ToV8String(jsEngine->GetIsolate(), name);
   v8::Local<v8::Object> obj = v8::Local<v8::Object>::Cast(UnwrapValue());
   return JsValue(jsEngine, obj->Get(property));
 }
 
 void AdblockPlus::JsValue::SetProperty(const std::string& name, v8::Handle<v8::Value> val)
 {
   if (!IsObject())
-    throw new std::runtime_error("Attempting to set property on a non-object");
+    throw std::runtime_error("Attempting to set property on a non-object");
 
   v8::Local<v8::String> property = Utils::ToV8String(jsEngine->GetIsolate(), name);
   v8::Local<v8::Object> obj = v8::Local<v8::Object>::Cast(UnwrapValue());
   obj->Set(property, val);
 }
 
 v8::Local<v8::Value> AdblockPlus::JsValue::UnwrapValue() const
 {
   return v8::Local<v8::Value>::New(jsEngine->GetIsolate(), *value);
 }
@@ skipping 24 matching lines @@
 
 void AdblockPlus::JsValue::SetProperty(const std::string& name, bool val)
 {
   const JsContext context(*jsEngine);
   SetProperty(name, v8::Boolean::New(jsEngine->GetIsolate(), val));
 }
 
 std::string AdblockPlus::JsValue::GetClass() const
 {
   if (!IsObject())
-    throw new std::runtime_error("Cannot get constructor of a non-object");
+    throw std::runtime_error("Cannot get constructor of a non-object");
 
   const JsContext context(*jsEngine);
   v8::Local<v8::Object> obj = v8::Local<v8::Object>::Cast(UnwrapValue());
   return Utils::FromV8String(obj->GetConstructorName());
 }
 
 JsValue JsValue::Call(const JsValueList& params) const
 {
   const JsContext context(*jsEngine);
   std::vector<v8::Handle<v8::Value>> argv;
@@ skipping 21 matching lines @@
 
   std::vector<v8::Handle<v8::Value>> argv;
   argv.push_back(arg.UnwrapValue());
 
   return Call(argv, context.GetV8Context()->Global());
 }
 
 JsValue JsValue::Call(std::vector<v8::Handle<v8::Value>>& args, v8::Local<v8::Object> thisObj) const
 {
   if (!IsFunction())
-    throw new std::runtime_error("Attempting to call a non-function");
+    throw std::runtime_error("Attempting to call a non-function");
   if (!thisObj->IsObject())
-    throw new std::runtime_error("`this` pointer has to be an object");
+    throw std::runtime_error("`this` pointer has to be an object");
 
   const JsContext context(*jsEngine);
 
   const v8::TryCatch tryCatch;
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   v8::Local<v8::Value> result = func->Call(thisObj, args.size(),
     args.size() ? &args[0] : nullptr);
 
   if (tryCatch.HasCaught())
     throw JsError(tryCatch.Exception(), tryCatch.Message());
 
   return JsValue(jsEngine, result);
 }