Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29497620: Noissue - don't throw a pointer to an exception in C++ (Closed)

Created:
July 25, 2017, 2:53 p.m. by sergei
Modified:
July 26, 2017, 5:15 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

Review: https://codereview.adblockplus.org/29497620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/JsValue.cpp View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2
sergei
July 25, 2017, 2:54 p.m. (2017-07-25 14:54:33 UTC) #1
hub
July 25, 2017, 3:20 p.m. (2017-07-25 15:20:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld