Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29498563: Issue 5133 - add CI for libadblockplus (Closed)

Created:
July 26, 2017, 12:31 p.m. by sergei
Modified:
Sept. 27, 2017, 7:39 a.m.
Reviewers:
hub
CC:
Felix Dahlke, Oleksandr, Eric
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# Having this in the main repo will not only build 'master' of libadblockplus when we push some changes, it will also simplify the development process. Right now one has to apply this patch each time before creating or updating a codereview, with this patch this step will disappear.

Patch Set 1 #

Total comments: 8

Patch Set 2 : edit dependencies #

Patch Set 3 : add arm64 #

Patch Set 4 : add osx #

Patch Set 5 : update v8 binaries in accordance with the currently used version of v8 #

Patch Set 6 : use real URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
A .appveyor/prepare-prebuilt-v8.cmd View 1 chunk +11 lines, -0 lines 0 comments Download
A .travis.yml View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download
A .travis/prepare-prebuilt-v8.sh View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A appveyor.yml View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 13
sergei
https://codereview.adblockplus.org/29498563/diff/29498564/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29498563/diff/29498564/.travis.yml#newcode24 .travis.yml:24: - URL_PREFIX=https://github.com/xxxz/v8-binaries2/releases/download/v1/ This URL will be changed, see similar ...
July 26, 2017, 12:52 p.m. (2017-07-26 12:52:52 UTC) #1
hub
https://codereview.adblockplus.org/29498563/diff/29498564/dependencies File dependencies (left): https://codereview.adblockplus.org/29498563/diff/29498564/dependencies#oldcode7 dependencies:7: third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe309ba9c2e3081 On 2017/07/26 12:52:52, sergei ...
July 26, 2017, 3:35 p.m. (2017-07-26 15:35:51 UTC) #2
sergei
https://codereview.adblockplus.org/29498563/diff/29498564/dependencies File dependencies (left): https://codereview.adblockplus.org/29498563/diff/29498564/dependencies#oldcode7 dependencies:7: third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe309ba9c2e3081 On 2017/07/26 15:35:51, hub ...
July 26, 2017, 3:44 p.m. (2017-07-26 15:44:40 UTC) #3
hub
https://codereview.adblockplus.org/29498563/diff/29498564/dependencies File dependencies (left): https://codereview.adblockplus.org/29498563/diff/29498564/dependencies#oldcode7 dependencies:7: third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe309ba9c2e3081 On 2017/07/26 15:44:40, sergei ...
July 26, 2017, 3:51 p.m. (2017-07-26 15:51:54 UTC) #4
sergei
https://codereview.adblockplus.org/29498563/diff/29498564/dependencies File dependencies (left): https://codereview.adblockplus.org/29498563/diff/29498564/dependencies#oldcode7 dependencies:7: third_party/v8 = v8-googlesource hg:b0526a8c076e git:97fafa7b1c277bcc627495318fe309ba9c2e3081 On 2017/07/26 15:51:53, hub ...
July 26, 2017, 4:45 p.m. (2017-07-26 16:45:46 UTC) #5
hub
LGTM
July 26, 2017, 4:57 p.m. (2017-07-26 16:57:53 UTC) #6
sergei
added arm64
Aug. 9, 2017, 8:03 a.m. (2017-08-09 08:03:17 UTC) #7
hub
LGTM
Aug. 9, 2017, 12:51 p.m. (2017-08-09 12:51:36 UTC) #8
sergei
add osx
Aug. 10, 2017, 12:27 p.m. (2017-08-10 12:27:29 UTC) #9
hub
LGTM
Aug. 10, 2017, 12:44 p.m. (2017-08-10 12:44:34 UTC) #10
sergei
It's just a notification of the change, despite it won't be included in the final ...
Sept. 19, 2017, 1:58 p.m. (2017-09-19 13:58:49 UTC) #11
sergei
It's ready to be pushed, the file server is here.
Sept. 26, 2017, 3:11 p.m. (2017-09-26 15:11:15 UTC) #12
hub
Sept. 26, 2017, 10 p.m. (2017-09-26 22:00:19 UTC) #13
LGTM

Powered by Google App Engine
This is Rietveld