Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine

src/ConsoleJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 27 matching lines @@
       if (i > 0)
         message << " ";
       message << converted[i].AsString();
     }
 
     std::stringstream source;
     v8::Local<v8::StackFrame> frame = v8::StackTrace::CurrentStackTrace(arguments.GetIsolate(), 1)->GetFrame(0);
     source << AdblockPlus::Utils::FromV8String(frame->GetScriptName());
     source << ":" << frame->GetLineNumber();
 
-    AdblockPlus::LogSystemPtr callback = jsEngine->GetLogSystem();
-    (*callback)(logLevel, message.str(), source.str());
+    AdblockPlus::LogSystem& callback = jsEngine->GetLogSystem();
+    callback(logLevel, message.str(), source.str());
   }
 
   void LogCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
   {
     return DoLog(AdblockPlus::LogSystem::LOG_LEVEL_LOG, arguments);
   }
 
   void DebugCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
   {
     DoLog(AdblockPlus::LogSystem::LOG_LEVEL_LOG, arguments);
@@ skipping 30 matching lines @@
       if (name.size())
         traceback << name;
       else
         traceback << "/* anonymous */";
       traceback << "() at ";
       traceback << AdblockPlus::Utils::FromV8String(frame->GetScriptName());
       traceback << ":" << frame->GetLineNumber();
       traceback << std::endl;
     }
 
-    AdblockPlus::LogSystemPtr callback = jsEngine->GetLogSystem();
-    (*callback)(AdblockPlus::LogSystem::LOG_LEVEL_TRACE, traceback.str(), "");
+    AdblockPlus::LogSystem& callback = jsEngine->GetLogSystem();
+    callback(AdblockPlus::LogSystem::LOG_LEVEL_TRACE, traceback.str(), "");
   }
 }
 
 AdblockPlus::JsValue& AdblockPlus::ConsoleJsObject::Setup(
     AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj)
 {
   obj.SetProperty("log", jsEngine.NewCallback(::LogCallback));
   obj.SetProperty("debug", jsEngine.NewCallback(::DebugCallback));
   obj.SetProperty("info", jsEngine.NewCallback(::InfoCallback));
   obj.SetProperty("warn", jsEngine.NewCallback(::WarnCallback));
   obj.SetProperty("error", jsEngine.NewCallback(::ErrorCallback));
   obj.SetProperty("trace", jsEngine.NewCallback(::TraceCallback));
   return obj;
 }