Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine (Closed)

Created:
July 26, 2017, 2:43 p.m. by sergei
Modified:
July 27, 2017, 7:55 a.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -59 lines) Patch
M include/AdblockPlus/JsEngine.h View 4 chunks +12 lines, -13 lines 0 comments Download
M include/AdblockPlus/LogSystem.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ConsoleJsObject.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/JsEngine.cpp View 3 chunks +12 lines, -15 lines 0 comments Download
M test/BaseJsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M test/ConsoleJsObject.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M test/JsEngine.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M test/WebRequest.cpp View 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 4
sergei
July 26, 2017, 2:45 p.m. (2017-07-26 14:45:37 UTC) #1
hub
https://codereview.adblockplus.org/29498576/diff/29498577/include/AdblockPlus/LogSystem.h File include/AdblockPlus/LogSystem.h (right): https://codereview.adblockplus.org/29498576/diff/29498577/include/AdblockPlus/LogSystem.h#newcode51 include/AdblockPlus/LogSystem.h:51: * Shared smart pointer to a `LogSystem` instance. nit: ...
July 26, 2017, 4:33 p.m. (2017-07-26 16:33:19 UTC) #2
sergei
https://codereview.adblockplus.org/29498576/diff/29498577/include/AdblockPlus/LogSystem.h File include/AdblockPlus/LogSystem.h (right): https://codereview.adblockplus.org/29498576/diff/29498577/include/AdblockPlus/LogSystem.h#newcode51 include/AdblockPlus/LogSystem.h:51: * Shared smart pointer to a `LogSystem` instance. On ...
July 26, 2017, 4:49 p.m. (2017-07-26 16:49:29 UTC) #3
hub
July 26, 2017, 4:58 p.m. (2017-07-26 16:58:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld