Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine

test/ConsoleJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
 
     void operator()(AdblockPlus::LogSystem::LogLevel logLevel,
         const std::string& message, const std::string& source)
     {
       lastLogLevel = logLevel;
       lastMessage = message;
       lastSource = source;
     }
   };
 
-  typedef std::shared_ptr<MockLogSystem> MockLogSystemPtr;
-
   class ConsoleJsObjectTest : public BaseJsTest
   {
   protected:
-    MockLogSystemPtr mockLogSystem;
+    MockLogSystem* mockLogSystem;
 
     void SetUp()
     {
-      BaseJsTest::SetUp();
-      mockLogSystem = MockLogSystemPtr(new MockLogSystem);
-      jsEngine->SetLogSystem(mockLogSystem);
+      JsEngineCreationParameters jsEngineParams;
+      jsEngineParams.logSystem.reset(mockLogSystem = new MockLogSystem());
+      jsEngine = CreateJsEngine(std::move(jsEngineParams));
     }
   };
 }
 
 TEST_F(ConsoleJsObjectTest, ConsoleLogCall)
 {
   jsEngine->Evaluate("\n\nconsole.log('foo', 'bar');\n\n", "eval");
   ASSERT_EQ(AdblockPlus::LogSystem::LOG_LEVEL_LOG, mockLogSystem->lastLogLevel);
   ASSERT_EQ("foo bar", mockLogSystem->lastMessage);
   ASSERT_EQ("eval:3", mockLogSystem->lastSource);
@@ skipping 41 matching lines @@
       })();\n\
     }\n\
     foo();", "eval");
   ASSERT_EQ(AdblockPlus::LogSystem::LOG_LEVEL_TRACE, mockLogSystem->lastLogLevel);
   ASSERT_EQ("\
 1: /* anonymous */() at eval:5\n\
 2: foo() at eval:6\n\
 3: /* anonymous */() at eval:8\n", mockLogSystem->lastMessage);
   ASSERT_EQ("", mockLogSystem->lastSource);
 }