include/AdblockPlus/LogSystem.h - Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: include/AdblockPlus/LogSystem.h

Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Left Patch Set: Created July 26, 2017, 2:43 p.m.

Right Patch Set: address comment Created July 26, 2017, 4:48 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2017 eyeo GmbH	3 * Copyright (C) 2006-2017 eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 30 matching lines...) Expand all Loading...
41 * @param logLevel Log level.	41 * @param logLevel Log level.

42 * @param message Log message.	42 * @param message Log message.

43 * @param source Source of the message, e.g. file name and line.	43 * @param source Source of the message, e.g. file name and line.

44 * Ignored when empty.	44 * Ignored when empty.

45 */	45 */

46 virtual void operator()(LogLevel logLevel, const std::string& message,	46 virtual void operator()(LogLevel logLevel, const std::string& message,

47 const std::string& source) = 0;	47 const std::string& source) = 0;

48 };	48 };

49	49

50 /**	50 /**

51 * Shared smart pointer to a `LogSystem` instance.	51 * Smart pointer to a `LogSystem` instance.
hub 2017/07/26 16:33:19 nit: it is no longer shared nit: it is no longer shared sergei 2017/07/26 16:49:29 Done. Show quoted text On 2017/07/26 16:33:19, hub wrote: > nit: it is no longer shared Done.
52 */	52 */

53 typedef std::unique_ptr<LogSystem> LogSystemPtr;	53 typedef std::unique_ptr<LogSystem> LogSystemPtr;

54 }	54 }

55	55

56 #endif	56 #endif

LEFT	RIGHT