include/AdblockPlus/LogSystem.h - Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include/AdblockPlus/LogSystem.h

Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created July 26, 2017, 2:43 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/AdblockPlus/LogSystem.h

diff --git a/include/AdblockPlus/LogSystem.h b/include/AdblockPlus/LogSystem.h

index 6a71d5cfa98daf9390825e913143bf9f5b54f436..ec160cac9e7d7dde04299e6330e8ec9adc00698d 100644

--- a/include/AdblockPlus/LogSystem.h

+++ b/include/AdblockPlus/LogSystem.h

@@ -50,7 +50,7 @@ namespace AdblockPlus

/**

* Shared smart pointer to a `LogSystem` instance.

hub 2017/07/26 16:33:19 nit: it is no longer shared

sergei 2017/07/26 16:49:29 Done.

- typedef std::shared_ptr<LogSystem> LogSystemPtr;

+ typedef std::unique_ptr<LogSystem> LogSystemPtr;

}

#endif

« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/ConsoleJsObject.cpp » ('j') | no next file with comments »