Unified Diff: test/BaseJsTest.cpp
Issue 29498576:
Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine (Closed)
Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: address comment
Created July 26, 2017, 4:48 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/JsEngine.cpp ('k')
|
test/ConsoleJsObject.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/BaseJsTest.cpp |
| diff --git a/test/BaseJsTest.cpp b/test/BaseJsTest.cpp |
| index 4239e4c2d33fadc9294758ce8fff23d32f544792..53c80a0c649847534cba510087d29f69ab7e7c00 100644 |
| --- a/test/BaseJsTest.cpp |
| +++ b/test/BaseJsTest.cpp |
| @@ -33,7 +33,7 @@ void DelayedTimer::ProcessImmediateTimers(DelayedTimer::SharedTasks& timerTasks) |
| } |
| JsEngineCreationParameters::JsEngineCreationParameters() |
| - : logSystem(std::make_shared<ThrowingLogSystem>()) |
| + : logSystem(new ThrowingLogSystem()) |
| , timer(new ThrowingTimer()) |
| , webRequest(new ThrowingWebRequest()) |
| , fileSystem(std::make_shared<ThrowingFileSystem>()) |
| @@ -45,7 +45,7 @@ AdblockPlus::JsEnginePtr CreateJsEngine(JsEngineCreationParameters&& jsEngineCre |
| auto jsEngine = AdblockPlus::JsEngine::New(jsEngineCreationParameters.appInfo, |
| std::move(jsEngineCreationParameters.timer), |
| std::move(jsEngineCreationParameters.fileSystem), |
| - std::move(jsEngineCreationParameters.webRequest)); |
| - jsEngine->SetLogSystem(std::move(jsEngineCreationParameters.logSystem)); |
| + std::move(jsEngineCreationParameters.webRequest), |
| + std::move(jsEngineCreationParameters.logSystem)); |
| return jsEngine; |
| } |
« no previous file with comments
|
« src/JsEngine.cpp ('k')
|
test/ConsoleJsObject.cpp » ('j')
|
no next file with comments »
