Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/JsEngine.cpp

Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: address comment Created July 26, 2017, 4:48 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/ConsoleJsObject.cpp ('k') | test/WebRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/JsEngine.cpp
diff --git a/test/JsEngine.cpp b/test/JsEngine.cpp
index 18116b22b5d60dd82bd222d9a5c13639949377de..537b414ee4582361c54eb5b72bc810e2d4f365ce 100644
--- a/test/JsEngine.cpp
+++ b/test/JsEngine.cpp
@@ -162,17 +162,6 @@ TEST_F(JsEngineTest, EventCallbacks)
ASSERT_FALSE(callbackCalled);
}
-TEST(NewJsEngineTest, CallbackGetSet)
-{
- AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
-
- ASSERT_TRUE(jsEngine->GetLogSystem());
- ASSERT_ANY_THROW(jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr()));
- AdblockPlus::LogSystemPtr logSystem(new AdblockPlus::DefaultLogSystem());
- jsEngine->SetLogSystem(logSystem);
- ASSERT_EQ(logSystem, jsEngine->GetLogSystem());
-}
-
TEST(NewJsEngineTest, GlobalPropertyTest)
{
AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New());
« no previous file with comments | « test/ConsoleJsObject.cpp ('k') | test/WebRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld